Skip to content

✨ Enhance NFT loading #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2023
Merged

✨ Enhance NFT loading #141

merged 2 commits into from
Jul 1, 2023

Conversation

@GabrielePicco
Copy link
Collaborator

@GabrielePicco GabrielePicco commented Jul 1, 2023 •
edited
Loading

Enhance NFT loading & Bug Fixes

Status Type ⚠️ Core Change Issue
Ready Enhance/Bug No -

Problem

  • Nfts loading failing with most RPCs due to rate limit
  • Due to a bug in Unity, Destroy was triggering an exception if exiting from play mode while the NFTs are still loading
  • Unused LoadJson method
  • sNFT were not displayed due to the check on amount == 1

Solution

  • Add a parameter to add a delay between calls (This is a temporary solution and will be superseded by Customizable Rate Limit #120 )
  • Add a Destroy with uses DestroyImmediate if the game is not running
  • Remove unused methods
  • Remove amount == 1 check

@GabrielePicco GabrielePicco merged commit e65f2b6 into main Jul 1, 2023
@GabrielePicco GabrielePicco deleted the enhance/nft-loading-6 branch July 1, 2023 10:29
GabrielePicco added a commit that referenced this pull request Jul 1, 2023
@GabrielePicco
✨ Enhance NFT loading (#141)
d9dc6c9 
* ✨ Enhance NFT loading

* ✨ Reduce min delay
GabrielePicco added a commit that referenced this pull request Jul 1, 2023
@GabrielePicco @abishekk92
✨ Add SessionWallet (#142)
64405d5 
* Add SessionWallet via Solana.Unity.Gum

* Add missing imports

* Add SessionWallet via Solana.Unity.Gum

* Add convenience methods

* Add XML comments

* Check if session token is initialized

* ⚡ Enhance NFT loading (#138)

* ✨ Enhance NFT loading (#141)

* ✨ Enhance NFT loading

* ✨ Reduce min delay

---------

Co-authored-by: abishekk92 <bhat.abishek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GabrielePicco