⚡ Xnft adapter #90
Merged
⚡ Xnft adapter #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of custom WebGLTemplates
…ry script injections and fixed Loader Filename
|
LGTM! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Remove the need of a custom WebGLTemplate and unify XNFT with the new WalletAdapter
Solution
Xnft is not a wallet adapter and not easily convertible, also seems we can't access some features trhough a injected script as we do wit the wallet-adapter-js, but we can still access all from the jslib
Other changes
New dependencies:
unity-js-wallet-adapter: depends on new version, still in development at branch xnft-helpersIssues
Closes #82