Skip to content

fix: set default base fee to 0 #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmuddha merged 1 commit into from
Dec 3, 2025
Merged

fix: set default base fee to 0 #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion magicblock-api/src/magic_validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ impl MagicValidator {
// In case if we have a perfect match between accountsdb and ledger slot
// (note: that accountsdb is always 1 slot ahead of ledger), then there's
// no need to run any kind of ledger replay
if accountsdb_slot - 1 == ledger_slot {
if accountsdb_slot.saturating_sub(1) == ledger_slot {
return Ok(());
}
// SOLANA only allows blockhash to be valid for 150 slot back in time,
Expand Down
1 change: 0 additions & 1 deletion magicblock-config/src/config/validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ use crate::{consts, types::SerdeKeypair};
#[serde(default, rename_all = "kebab-case", deny_unknown_fields)]
pub struct ValidatorConfig {
/// The minimum fee (in lamports) required to process a transaction.
/// Defaults to 100 lamports.
pub basefee: u64,

/// The validator's identity keypair, encoded in Base58.
Expand Down
2 changes: 1 addition & 1 deletion magicblock-config/src/consts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub const DEFAULT_STORAGE_DIRECTORY: &str = "magicblock-test-storage/";
// MUST provide their own keypair via config file, env var or CLI argument
pub const DEFAULT_VALIDATOR_KEYPAIR: &str =
"9Vo7TbA5YfC5a33JhAi9Fb41usA6JwecHNRw3f9MzzHAM8hFnXTzL5DcEHwsAFjuUZ8vNQcJ4XziRFpMc3gTgBQ";
pub const DEFAULT_BASE_FEE: u64 = 100;
pub const DEFAULT_BASE_FEE: u64 = 0;
pub const DEFAULT_COMPUTE_UNIT_PRICE: u64 = 1_000_000;

// Remote URL Aliases
Expand Down