Skip to content

Conversation

@bmuddha
Copy link
Contributor

@bmuddha bmuddha commented Dec 5, 2025

This PR removes all of the dangling dependencies throughout the primary workspace. The number of build dependencies has been reduced by 20% as a result of this cleanup.

Summary by CodeRabbit

Release Notes

  • Chores
    • Streamlined project dependencies to reduce build complexity and improve maintenance efficiency. Several unused or redundant dependencies have been removed across multiple components.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Manual Deploy Available

You can trigger a manual deploy of this PR branch to testnet:

Deploy to Testnet 🚀

Alternative: Comment /deploy on this PR to trigger deployment directly.

⚠️ Note: Manual deploy requires authorization. Only authorized users can trigger deployments.

Comment updated automatically when the PR is synchronized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

This PR removes unused dependencies across the workspace and individual crates. Changes include removal of workspace-level dependencies (borsh-derive, cargo-lock, const_format, convert_case, hostname, itertools, proc-macro2, quote, serde_derive, and various Solana-related crates) and crate-specific dependencies (serde, magicblock-delegation-program, futures-util, solana-rpc-client, clap, and others). No new dependencies are added, and no public API declarations are modified. The net effect is a reduction in the overall dependency graph footprint across multiple crates.

Possibly related PRs

  • Rpc/execution related metrics #584: Adds and uses magicblock-metrics across crates, while this PR removes magicblock-metrics from workspace and crate manifests—directly inverse relationship in metric handling.

Suggested reviewers

  • thlorenz
  • Dodecahedr0x
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bmuddha/chore/remove-unused-deps

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c723077 and 2cd5b57.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (16)
  • Cargo.toml (0 hunks)
  • magicblock-accounts-db/Cargo.toml (0 hunks)
  • magicblock-accounts/Cargo.toml (0 hunks)
  • magicblock-aperture/Cargo.toml (0 hunks)
  • magicblock-api/Cargo.toml (0 hunks)
  • magicblock-chainlink/Cargo.toml (0 hunks)
  • magicblock-committor-program/Cargo.toml (0 hunks)
  • magicblock-config/Cargo.toml (0 hunks)
  • magicblock-core/Cargo.toml (0 hunks)
  • magicblock-ledger/Cargo.toml (0 hunks)
  • magicblock-rpc-client/Cargo.toml (0 hunks)
  • magicblock-table-mania/Cargo.toml (0 hunks)
  • magicblock-task-scheduler/Cargo.toml (0 hunks)
  • magicblock-validator-admin/Cargo.toml (0 hunks)
  • magicblock-validator/Cargo.toml (0 hunks)
  • programs/magicblock/Cargo.toml (0 hunks)
💤 Files with no reviewable changes (16)
  • magicblock-ledger/Cargo.toml
  • magicblock-config/Cargo.toml
  • magicblock-chainlink/Cargo.toml
  • magicblock-validator-admin/Cargo.toml
  • magicblock-core/Cargo.toml
  • magicblock-aperture/Cargo.toml
  • magicblock-table-mania/Cargo.toml
  • magicblock-rpc-client/Cargo.toml
  • magicblock-accounts-db/Cargo.toml
  • magicblock-committor-program/Cargo.toml
  • magicblock-validator/Cargo.toml
  • magicblock-accounts/Cargo.toml
  • magicblock-api/Cargo.toml
  • programs/magicblock/Cargo.toml
  • Cargo.toml
  • magicblock-task-scheduler/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

bmuddha commented Dec 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bmuddha bmuddha changed the title feat: cargo udeps chore: remove unused dependencies in the workspace Dec 5, 2025
@bmuddha bmuddha marked this pull request as ready for review December 5, 2025 14:02
Copy link
Collaborator

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor Author

bmuddha commented Dec 5, 2025

Merge activity

  • Dec 5, 2:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 2:36 PM UTC: @bmuddha merged this pull request with Graphite.

@bmuddha bmuddha merged commit 05ee6aa into master Dec 5, 2025
26 checks passed
@bmuddha bmuddha deleted the bmuddha/chore/remove-unused-deps branch December 5, 2025 14:36
thlorenz added a commit that referenced this pull request Dec 9, 2025
* master:
  feat: add program subscription support (#703)
  feat: add a way to remove confined accounts on start (#726)
  chore: remove unused dependencies in the workspace  (#732)
  fix: prevent removal of delegated/undelegating accounts on eviction (#724)
  fix: Fix per-account livelock (#728)
  fix: properly prune program cache upon corruption (#730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants