Skip to content

Conversation

@ajay-kashyap
Copy link
Contributor

@ajay-kashyap ajay-kashyap commented Aug 18, 2022

Signed-off-by: Ajay-Kashyap ajay.kashyap@wavelabs.ai

Summary

Handling corner cases in Session modification response flow for Add & Delete cases.

Test Plan

Session modification Add/Delete is performed.

Packet_sm_16sep.zip
syslog_sm_16sep.zip

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 18, 2022
@ajay-kashyap ajay-kashyap self-assigned this Aug 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 5576ff9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

dp-workflow

14 tests   14 ✔️  2m 22s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 5576ff9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

agw-workflow

615 tests   611 ✔️  3m 51s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 5576ff9.

♻️ This comment has been updated with latest results.

@Sathyaj27 Sathyaj27 requested a review from panyogesh August 19, 2022 07:15
@panyogesh
Copy link
Contributor

Signed-off-by: Ajay-Kashyap ajay.kashyap@wavelabs.ai

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

Please update the summary, Explain fix and test plan

…n response.

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>
Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>
@ajay-kashyap ajay-kashyap marked this pull request as ready for review September 26, 2022 05:58
@ajay-kashyap ajay-kashyap requested a review from a team September 26, 2022 05:58
@ajahl ajahl merged commit 10f717f into magma:master Sep 27, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
…n response (magma#13655)

* fix(mme): Handling  qosflowFailedForAddorModify in session modification response.

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>

* Session modification corner case handling

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>
edaspb pushed a commit to edaspb/magma that referenced this pull request Apr 28, 2023
…n response (magma#13655)

* fix(mme): Handling  qosflowFailedForAddorModify in session modification response.

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>

* Session modification corner case handling

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>

Signed-off-by: Ajay-Kashyap <ajay.kashyap@wavelabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue product: 5g sa size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants