chore(dp): Get rid of legacy active-mode controller #13906

sklgromek · 2022-09-13T08:48:58Z

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

Remove legacy active-mode controller as it was moved to orc8r
included domain proxy path in GH actions cloud-workflow

Test Plan

check CI

Additional Information

This change is backwards-breaking

github-actions · 2022-09-13T08:49:17Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-13T09:15:04Z

dp-workflow

14 tests 14 ✔️ 2m 28s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 9635928.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-13T10:01:26Z

cloud-workflow

1 130 tests 1 130 ✔️ 2m 21s ⏱️
  367 suites       0 💤
      7 files       0 ❌

Results for commit 9635928.

♻️ This comment has been updated with latest results.

jheidbrink · 2022-09-15T07:04:05Z

.github/workflows/cloud-workflow.yml

          filters: |
            filesChanged:
-              - [".github/workflows/cloud-workflow.yml", "lte/protos/**", "cwf/cloud/**", "feg/cloud/**", "lte/cloud/**", "orc8r/**"]
+              - [".github/workflows/cloud-workflow.yml", "lte/protos/**", "cwf/cloud/**", "feg/cloud/**", "lte/cloud/**", "orc8r/**", "dp/protos/**", "dp/cloud/go/**"]


This is already fixed on master.

jheidbrink

CI changes look good to me.

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

* chore(dp): New AmcManager CreateRequest func (magma#13908) * chore(dp): New AmcManager CreateRequest func Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> * imports Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> * fix TestWithinTx tests Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> (cherry picked from commit 94547e4) * chore(dp): Implement AmcManager DeleteCbsd func (magma#13921) Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> (cherry picked from commit 1a22cca) * fix(dp): make 37 default value for max_eirp (magma#13922) Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Co-authored-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> (cherry picked from commit 0589db4) * chore(dp): Implement AmcManager UpdateCbsd func (magma#13927) Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> (cherry picked from commit da0d251) * chore(dp): WithinTx should not suppress panic (magma#13933) Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> (cherry picked from commit 1212843) * chore(dp): Get rid of legacy active-mode controller (magma#13906) Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com> Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com> (cherry picked from commit 11896c1) * feat(dp): Implement GetState in DP orc8r service (magma#13914) * feat(dp): Implement GetState in DP orc8r service Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * fixes Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * adding test with more cbsds and grants Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * fixes after rebase Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Co-authored-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> (cherry picked from commit cadd2b8) * chore(dp): Fix domain-proxy build job (magma#13937) Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com> Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com> (cherry picked from commit 3356cb0) * feat(dp): Use database directly in AMC (magma#13930) Previously AMC used additional grpc service to communicate with the database, but it was inefficient. Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com> Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com> (cherry picked from commit e718514) * chore(orc8r): Add missing dp enabled parameter to terraform input template (magma#13934) Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com> (cherry picked from commit 0118afd) * chore(dp): Preallocate memory when collecting column pointers (magma#13890) Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com> Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com> (cherry picked from commit 0e293ef) * chore(dp): supressed radio controller operation (magma#13925) Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Co-authored-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> (cherry picked from commit b8ad056) * feat(dp): add DeleteGrant handler to AmcManager Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * chore(dp): Remove unsetting frequencies from CC Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> * chore(dp): remove idle grants in AMC Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> * chore(dp): grantManager sets CBSD's available frequencies Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> * perf(dp): Batch logging in Configuration Controller Instead of sending logs one by one during Configuration Controller's request/response processing, send all logs related to requests in a http batch to fluentd, as an array of individual logs. This change reduces the time footprint it takes for 1 log to be processed by fluentd, and should greatly improve request processing performance by not waiting for each log to be sent and processed. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com> * perf(dp): logging in separate thread, session improvements Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * perf(dp): fake sas respects heartbeat timed out * fix async logs Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * chore(dp): sort requests from the oldest in CC * fix(dp): cbsd manager must return idle grants, otherwise they won't be deleted * fix(dp): relinquish should ignore idle grants * fix(dp): do not relinquish idle grants Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> * fix(dp): relinquish should not unset frequencies * fix(dp): change expected value in test_activity_status Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Signed-off-by: Jarosław Jaszczuk <jaroslaw@freedomfi.com> Signed-off-by: Artur Dębski <artur.debski@freedomfi.com> Co-authored-by: WojSad <81693058+WojSad@users.noreply.github.com> Co-authored-by: Tomasz Gromowski <tomasz@freedomfi.com> Co-authored-by: jkmar <jkmar@users.noreply.github.com> Co-authored-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>

sklgromek requested review from a team and jkmar September 13, 2022 08:48

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Sep 13, 2022

github-actions bot added component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue labels Sep 13, 2022

sklgromek force-pushed the dp-remove-active-mode-controller branch from 2912f5a to 19f9a42 Compare September 13, 2022 09:21

sklgromek requested a review from a team as a code owner September 13, 2022 09:21

sklgromek requested a review from rdefosse September 13, 2022 09:21

pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Sep 13, 2022

github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 13, 2022

sklgromek force-pushed the dp-remove-active-mode-controller branch 2 times, most recently from dc83460 to 195b2c2 Compare September 13, 2022 09:37

jheidbrink reviewed Sep 15, 2022

View reviewed changes

jheidbrink approved these changes Sep 15, 2022

View reviewed changes

jkmar approved these changes Sep 15, 2022

View reviewed changes

chore(dp): Get rid of legacy active-mode controller

9635928

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

sklgromek force-pushed the dp-remove-active-mode-controller branch from 195b2c2 to 9635928 Compare September 15, 2022 09:43

jkmar merged commit 11896c1 into magma:master Sep 15, 2022

jkmar deleted the dp-remove-active-mode-controller branch September 15, 2022 10:58

jheidbrink mentioned this pull request Sep 19, 2022

fix(ci): Add missing paths to path filter #13959

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(dp): Get rid of legacy active-mode controller #13906

chore(dp): Get rid of legacy active-mode controller #13906

Uh oh!

sklgromek commented Sep 13, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Sep 13, 2022

Uh oh!

github-actions bot commented Sep 13, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Sep 13, 2022 •

edited

Loading

Uh oh!

jheidbrink Sep 15, 2022

Uh oh!

jheidbrink left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore(dp): Get rid of legacy active-mode controller #13906

chore(dp): Get rid of legacy active-mode controller #13906

Uh oh!

Conversation

sklgromek commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Additional Information

Uh oh!

github-actions bot commented Sep 13, 2022

Howto

More info

Uh oh!

github-actions bot commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dp-workflow

Uh oh!

github-actions bot commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cloud-workflow

Uh oh!

jheidbrink Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

jheidbrink left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sklgromek commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading