Skip to content

fix for uplink interface #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpgermano merged 1 commit into from
Sep 23, 2020
Merged

fix for uplink interface #2885

mpgermano merged 1 commit into from
Sep 23, 2020

Conversation

@bennojoy
Copy link
Contributor

@bennojoy bennojoy commented Sep 23, 2020

Signed-off-by: Benno Joy bennojoy@fb.com

 [xwfm] fix couple if bugs.

Summary

This fixes the below things.

  1. if uplink_if is null and the variable exists, the deployment fails to add dhcp server since it thinks we have an uplink interface.
  2. the update job didnt have execute permission hence couldnt be run.
  3. added the arp kernel parameters so that it can scale beyond 1k users.

Test Plan

tested in my devserver.

Additional Information

fix for uplink interface
0897900 
Signed-off-by: Benno Joy <bennojoy@fb.com>
@mpgermano mpgermano merged commit 0f9260a into magma:master Sep 23, 2020
rdefosse pushed a commit to rdefosse/magma that referenced this pull request Oct 9, 2020
@rdefosse
fix for uplink interface (magma#2885)
c0c8908 
Signed-off-by: Benno Joy <bennojoy@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aharonnovo aharonnovo Awaiting requested review from aharonnovo

@AyliD AyliD Awaiting requested review from AyliD

1 more reviewer

@r-i-g r-i-g r-i-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bennojoy @r-i-g @mpgermano