Skip to content

Conversation

@wallyrb
Copy link
Contributor

@wallyrb wallyrb commented Dec 11, 2020

Signed-off-by: Wally Rodriguez B wallyrb@fb.com

Summary

Adding evend and td-agent-bit on dynamic_services, in order to have event and log aggregation by default enabled after adding a new AGW in NMS.

Test Plan

Tested locally(attached video)

image

nms_log_event_agg.mov.zip

Signed-off-by: Wally Rodriguez B <wallyrb@fb.com>
@karthiksubraveti
Copy link
Contributor

@wallyrb run yarn eslint --fix ./packages/magmalte/app from magma/nms/app to resolve these errors.
You might want to fix the test GatewayConfigTest as well.
Thanks

@wallyrb
Copy link
Contributor Author

wallyrb commented Dec 11, 2020

@wallyrb run yarn eslint --fix ./packages/magmalte/app from magma/nms/app to resolve these errors.
You might want to fix the test GatewayConfigTest as well.
Thanks

Thanks Karthik I tried to run the yarn elist --fix, but got this error

wallyrb@wallyrb-mbp app % yarn eslint --fix ./packages/magmalte/app
yarn run v1.22.10
$ ./node_modules/.bin/eslint --ignore-path .eslintignore --fix ./packages/magmalte/app
/bin/sh: ./node_modules/.bin/eslint: No such file or directory
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
wallyrb@wallyrb-mbp app % 

I did modified the GatewayConfigTest, it seems the tests are passing, but could you double check again the PR? Thanks!

@karthiksubraveti karthiksubraveti self-requested a review December 11, 2020 14:35
Copy link
Contributor

@karthiksubraveti karthiksubraveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test

@karthiksubraveti karthiksubraveti merged commit e4d06bb into magma:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants