Skip to content

[nms]Fix lint errors in GatewayDetailConfig #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

[nms]Fix lint errors in GatewayDetailConfig #4022

merged 1 commit into from
Dec 11, 2020

Conversation

@wallyrb
Copy link
Contributor

@wallyrb wallyrb commented Dec 11, 2020

Signed-off-by: Wally Rodriguez B wallyrb@fb.com

Summary

Fixed lint errors in GatewayDetailConfigEdit and GatewayConfigTest

Test Plan

yarn tests results:

Test Suites: 26 passed, 26 total
Tests:       87 passed, 87 total
Snapshots:   0 total
Time:        16.204 s
Ran all test suites in 2 projects.
✨  Done in 18.50s.

@wallyrb
[nms]Fix lint errors in GatewayDetailConfig
388c697 
Signed-off-by: Wally Rodriguez B <wallyrb@fb.com>
@wallyrb wallyrb marked this pull request as ready for review December 11, 2020 19:00
@karthiksubraveti karthiksubraveti merged commit 32eaf8e into magma:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreilee andreilee Awaiting requested review from andreilee

@Scott8440 Scott8440 Awaiting requested review from Scott8440

@xjtian xjtian Awaiting requested review from xjtian

1 more reviewer

@karthiksubraveti karthiksubraveti karthiksubraveti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wallyrb @karthiksubraveti