[nms] handle failed api request when creating tier as errors #4057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymasmoudi
requested review from
Scott8440,
andreilee,
karthiksubraveti and
xjtian
as code owners
ymasmoudi
force-pushed
the
nms_tier_creation_blank_page_fix
branch
from
6783d0e to
e105aa6
Compare
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
ymasmoudi
changed the title
ymasmoudi
changed the title
ymasmoudi
force-pushed
the
nms_tier_creation_blank_page_fix
branch
from
e105aa6 to
41f912a
Compare
karthiksubraveti
approved these changes
Dec 15, 2020
Contributor
karthiksubraveti
left a comment
karthiksubraveti
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YOUSSEF EL MASMOUDI ymasmoudi@fb.com
Summary
Creating a tier with an invalid ID (space or dash for example) will redirect the user to a blanc page and no error message.
Test Plan
Tested locally