[Bug_Fix] [MME] Fixed MME crash for stale ENB cleanup issue #5707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinashakAnkitAman
requested review from
ardzoht,
lionelgo,
ssanadhya and
ulaskozat
as code owners
Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
ssanadhya
suggested changes
Mar 24, 2021
Contributor
|
@ardzoht were you able to reproduce this issue? |
Contributor
@ulaskozat I could not reproduce given issue using 100, 500 and 1000 UEs on continuous attach test, that being said, I think we should still go ahead and merge this since anyways covers for the past stale crash and should not have a side effect on other process. |
electronjoe
pushed a commit
to electronjoe/magma
that referenced
this pull request
Apr 16, 2021
Signed-off-by: Ankit Kumar Aman <ankit.aman@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Bug_Fix] [MME] Fixed MME crash for stale enb cleanup issue
Summary
MME was crashing sometimes when running test case test_continuous_random_attach.py in loop for large number of UEs. The reason was that sometimes the stale ENB entry was not cleaned up before the next test case execution and while cleaning the stale ENB entry during next s1ap association, the old ENB association was tried to get removed twice. This was leading to access of invalid pointer and crashing the MME. This PR fixes the issue.
Test Plan
Verified with sanity and multiple executions of test case test_continuous_random_attach.py
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com