Skip to content

Conversation

@themarwhal
Copy link
Member

Signed-off-by: Marie Bremner marwhal@fb.com

Summary

Load commit_hash environment and set it as the release version. (This is what we do for python services as well)

Test Plan

Tested with local setup.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Marie Bremner <marwhal@fb.com>
@themarwhal themarwhal requested a review from uri200 as a code owner April 8, 2021 18:59
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Apr 8, 2021
@magmabot magmabot added the component: agw Access gateway-related issue label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #6047 (a2ad106) into master (f036d4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6047   +/-   ##
=======================================
  Coverage   34.02%   34.02%           
=======================================
  Files        1132     1132           
  Lines       99654    99654           
  Branches     1307     1307           
=======================================
  Hits        33908    33908           
  Misses      62404    62404           
  Partials     3342     3342           
Flag Coverage Δ
c_cpp 8.18% <ø> (ø)
cloud_lint 66.38% <ø> (ø)
feg-lint 56.19% <ø> (ø)
lte-test 72.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lte/gateway/c/session_manager/sessiond_main.cpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f036d4a...a2ad106. Read the comment docs.

@themarwhal themarwhal merged commit 751d074 into magma:master Apr 8, 2021
@themarwhal themarwhal deleted the add-sentry-release-version branch April 8, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue sentry size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants