Skip to content

Conversation

@andreilee
Copy link
Contributor

@andreilee andreilee commented Apr 9, 2021

Signed-off-by: Andrei Lee andreilee@fb.com

Summary

For NMS/orc8r DB unification, the @fbcnms/sequelize-models package is used. Version 0.1.6 includes a fix for migrating the SequelizeMeta table.

Test Plan

See here

Additional Information

  • This change is backwards-breaking

Signed-off-by: Andrei Lee <andreilee@fb.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6058 (68adeda) into master (3286b3c) will increase coverage by 30.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6058       +/-   ##
===========================================
+ Coverage   34.01%   64.79%   +30.78%     
===========================================
  Files        1132      657      -475     
  Lines       99648    45470    -54178     
  Branches     1307     1307               
===========================================
- Hits        33894    29464     -4430     
+ Misses      62412    12664    -49748     
  Partials     3342     3342               
Flag Coverage Δ
c_cpp ?
cloud_lint 66.38% <ø> (ø)
feg-lint 56.19% <ø> (ø)
lte-test 72.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lte/gateway/c/oai/tasks/nas/emm/emm_data_ctx.c
...way/c/oai/lib/sgs_client/itti_msg_to_proto_msg.cpp
.../oai/tasks/nas5g/src/M5GAuthenticationResponse.cpp
.../gateway/c/oai/common/redis_utils/redis_client.cpp
...y/c/oai/tasks/nas/emm/msg/ExtendedServiceRequest.c
.../gateway/c/oai/tasks/nas/api/network/nas_message.c
...as/esm/msg/ActivateDefaultEpsBearerContextAccept.c
lte/gateway/c/oai/tasks/nas/ies/EsmCause.c
lte/gateway/c/oai/tasks/sgs/sgs_service_handler.c
...te/gateway/c/oai/tasks/nas/nas_state_converter.cpp
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3286b3c...68adeda. Read the comment docs.

@karthiksubraveti karthiksubraveti merged commit 6ec27ca into magma:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants