This repository was archived by the owner on Jan 7, 2020. It is now read-only.
feat/XOR-URL: added getXorUrl experimental function to the ImmutableData Reader
#354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterlester
previously approved these changes
Mar 12, 2019
joshuef
reviewed
Mar 13, 2019
src/api/immutable.js
Outdated
| * try { | ||
| * const cipherOpt = await app.cipherOpt.newPlainText(); | ||
| * const iDataWriter = await app.immutableData.create() | ||
| * const data = 'Most proteins are glycosylated. |
Contributor
There was a problem hiding this comment.
For multiline text, I think ``` is cleaner that ' (github is flagging this up as being an error, eg).
Contributor
Author
There was a problem hiding this comment.
let me take a look a this, and correct all docs that use' if it works with your suggestion
joshuef
previously approved these changes
Mar 13, 2019
…eData Reader which generates the XOR-URL of an already existing and fetched ImmutableData
bochaco
force-pushed
the
issue-353-immd-xor-url
branch
from
d9f99ef to
9107bbb
Compare
joshuef
approved these changes
Mar 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
getXorUrlexperimental function to the ImmutableData Reader which generates the XOR-URL of an already existing and fetched ImmutableData. Up until now you can get ImmD XOR-URL only when storing it on the network, with this you can get it after fetching it with its xorname.Resolves #353