Add context to client request #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2021
Closed
stek29
reviewed
Oct 29, 2021
updates.go
Outdated
|
|
||
| func (u *Updater) GetLastEvents(pollTime int) ([]*Event, error) { | ||
| events, err := u.client.GetEvents(u.lastEventID, pollTime) | ||
| func (u *Updater) GetLastEvents(ctx context.Context, pollTime int) ([]*Event, error) { |
There was a problem hiding this comment.
This breaks backwards compatibility for GetLastEvents — maybe GetLastEventsWithContext should be added instead?
There was a problem hiding this comment.
Thanks for reviewing!
Wraps GetEvents and GetLastEvents with non-context signature.
ghost
changed the title
DmitryDorofeev
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16