fix: fix remove organization member (#417)

Author: BrRenat

src/actions/organization/members/list.js

@@ -35,7 +35,7 @@ async function organizationMembersList({ params }) {
       id: organizationId,
       type: 'organizationMembers',
       attributes: members.map(member => ({
-        id: member.username,
+        id: member.id,
         type: 'organizationMember',
         attributes: member,
       })),

src/actions/organization/members/remove.js

@@ -26,16 +26,17 @@ async function removeMember({ params }) {
   const { audience } = config.organizations;
 
   const userId = await getUserId.call(this, username);
-  const memberKey = redisKey(userId, USERS_METADATA, audience);
-  const userInOrganization = await redis.hget(memberKey, organizationId);
+  const memberKey = redisKey(organizationId, ORGANIZATIONS_MEMBERS, userId);
+  const memberMetadataKey = redisKey(userId, USERS_METADATA, audience);
+  const userInOrganization = await redis.hget(memberMetadataKey, organizationId);
   if (!userInOrganization) {
     throw ErrorUserNotMember;
   }
 
   const pipeline = redis.pipeline();
   pipeline.del(memberKey);
   pipeline.zrem(redisKey(organizationId, ORGANIZATIONS_MEMBERS), memberKey);
-  pipeline.hdel(memberKey, organizationId);
+  pipeline.hdel(memberMetadataKey, organizationId);
 
   return pipeline.exec().then(handlePipeline);
 }

test/suites/organization/members/remove.js

@@ -28,9 +28,16 @@ describe('#remove member from organization', function registerSuite() {
       username: this.userNames[0].email,
     };
 
-    return this.dispatch('users.organization.members.remove', opts)
+    await this.dispatch('users.organization.members.remove', opts)
       .reflect()
       .then(inspectPromise(true));
+
+    return this.dispatch('users.organization.members.list', { organizationId: this.organization.id })
+      .reflect()
+      .then(inspectPromise(true))
+      .then((response) => {
+        assert.strictEqual(response.data.attributes.find(({ attributes }) => attributes.username === this.userNames[0].email), undefined);
+      });
   });
 
   it('must return organization not found error', async function test() {