Skip to content

feat: use @microfleet/validation#383

Merged
AVVS merged 9 commits intomasterfrom
feat/migrate-ms-validation
Oct 16, 2018
Merged

feat: use @microfleet/validation#383
AVVS merged 9 commits intomasterfrom
feat/migrate-ms-validation

Conversation

@AVVS
Copy link
Copy Markdown
Member

@AVVS AVVS commented Oct 15, 2018

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2018

Codecov Report

Merging #383 into master will decrease coverage by 0.11%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   94.31%   94.19%   -0.12%     
==========================================
  Files         104      104              
  Lines        1828     1862      +34     
==========================================
+ Hits         1724     1754      +30     
- Misses        104      108       +4
Impacted Files Coverage Δ
src/configs/jwt.js 100% <ø> (ø) ⬆️
src/utils/updateMetadata.js 100% <100%> (ø) ⬆️
src/utils/scrypt.js 86.95% <66.66%> (-3.52%) ⬇️
src/utils/userData/getInternalData.js 93.54% <85.71%> (-2.46%) ⬇️
src/users.js 91.37% <91.66%> (-0.93%) ⬇️
src/actions/login.js 95.94% <94.11%> (+1.5%) ⬆️
src/auth/oauth/hapi.js 86.11% <0%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a7c8f...c685454. Read the comment docs.

@AVVS AVVS merged commit 311334d into master Oct 16, 2018
@AVVS AVVS deleted the feat/migrate-ms-validation branch October 16, 2018 02:54
AVVS pushed a commit that referenced this pull request Oct 16, 2018
# [10.0.0](v9.5.0...v10.0.0) (2018-10-16)

### Features

* use [@microfleet](https://github.com/microfleet)/validation ([#383](#383)) ([311334d](311334d))

### BREAKING CHANGES

* uses new @microfleet/validation, potentially changing returned error types. Adds new global remote ip login tracker
@AVVS
Copy link
Copy Markdown
Member Author

AVVS commented Oct 16, 2018

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant