feat(ms-users): 429 error add more info#412
Merged
annahassel merged 4 commits intomakeomatic:masterfrom Sep 13, 2019
Merged
Conversation
annahassel
reviewed
Aug 28, 2019
| }); | ||
|
|
||
| it('must fail to send challenge email more than once in an hour per user', function test() { | ||
| const msgRe = /^We've already sent you an email, if it doesn't come - please try again in (.*) or send us an email$/; |
Collaborator
Author
There was a problem hiding this comment.
'5 minutes' !~ /\d+/ ((( some other too
annahassel
reviewed
Aug 28, 2019
| }); | ||
|
|
||
| it('must fail to send challeng email during race condition', function test() { | ||
| const msgRe = /^We've already sent you an email, if it doesn't come - please try again in (.*) or send us an email$/; |
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 94.57% 94.49% -0.09%
==========================================
Files 130 130
Lines 2361 2343 -18
==========================================
- Hits 2233 2214 -19
- Misses 128 129 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 94.52% 94.53% +<.01%
==========================================
Files 130 130
Lines 2375 2377 +2
==========================================
+ Hits 2245 2247 +2
Misses 130 130
Continue to review full report at Codecov.
|
* challenge tests logic change
* no ip vars in error messages
* no duration var - used scalar
pajgo
force-pushed
the
feat/pretty429error
branch
from
802fe87 to
489a79c
Compare
AVVS
pushed a commit
that referenced
this pull request
Sep 13, 2019
# [11.3.0](v11.2.7...v11.3.0) (2019-09-13) ### Features * **ms-users:** 429 error add more info ([#412](#412)) ([6f989a8](6f989a8))
Member
|
🎉 This PR is included in version 11.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ipaddress in HttpError 429 messages