Conversation
* tests * missing param
* remove redis TIME * hires on client side
* rfc update * ratelimiters config schema and enabled option
* forever blocks test fix
* schemas update
* ip token cleanup
* sentinel conf reset * spaces
* rework + fixes
* rfc update * hirestimestamp to timestamp
AVVS
reviewed
Dec 16, 2019
| name: 'Error', | ||
| stack: | ||
| 'Error: BadError\n at Object.internal (/src/test/suites/oauth/facebook.js:106:28)\n at Object.invoke (/src/node_modules/sinon/lib/sinon/behavior.js:151:35)\n at module.exports.internals.Auth.functionStub (/src/node_modules/sinon/lib/sinon/stub.js:130:47)\n at Function.invoke (/src/node_modules/sinon/lib/sinon/spy.js:297:51)\n at module.exports.internals.Auth.functionStub (/src/node_modules/sinon/lib/sinon/spy.js:90:30)\n at Users.test (/src/src/auth/oauth/index.js:149:45)\n at Users.tryCatcher (/src/node_modules/bluebird/js/release/util.js:16:23)\n at Promise._settlePromiseFromHandler (/src/node_modules/bluebird/js/release/promise.js:517:31)\n at Promise._settlePromise (/src/node_modules/bluebird/js/release/promise.js:574:18)\n at Promise._settlePromiseCtx (/src/node_modules/bluebird/js/release/promise.js:611:10)\n at _drainQueueStep (/src/node_modules/bluebird/js/release/async.js:142:12)\n at _drainQueue (/src/node_modules/bluebird/js/release/async.js:131:9)\n at Async._drainQueues (/src/node_modules/bluebird/js/release/async.js:147:5)\n at Immediate.Async.drainQueues [as _onImmediate] (/src/node_modules/bluebird/js/release/async.js:17:14)\n at runCallback (timers.js:705:18)\n at tryOnImmediate (timers.js:676:5)\n at processImmediate (timers.js:658:5)', | ||
| utils, |
AVVS
reviewed
Dec 16, 2019
|
|
||
| E.g.: | ||
| ```javascript | ||
| const SlidingWindowlimiter = require(utils); |
AVVS
pushed a commit
that referenced
this pull request
Dec 17, 2019
# [13.0.0](v12.1.4...v13.0.0) (2019-12-17) ### Features * sliding window rate limitation for sign in ([#438](#438)) ([1b4273c](1b4273c)) ### BREAKING CHANGES * implements new rate limiting algorithm using sliding window. While overall the mechanics of rate limiting remain the same - it's now harder to lock out the ip completely as each unsuccessful attempt wont extend login attempt capture duration for another <keep login attempts time>. Consult with the docs on a new configuration format for the rate limiter
Member
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.