feat: add sender info to invitation email#502
Merged
AVVS merged 4 commits intomakeomatic:stagingfrom Mar 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #502 +/- ##
===========================================
+ Coverage 87.27% 87.31% +0.04%
===========================================
Files 163 164 +1
Lines 3158 3169 +11
===========================================
+ Hits 2756 2767 +11
Misses 402 402
Continue to review full report at Codecov.
|
AVVS
pushed a commit
that referenced
this pull request
Mar 30, 2021
# [14.19.0-rc.1](v14.18.0...v14.19.0-rc.1) (2021-03-30) ### Bug Fixes * clear changelog [skip ci] ([af3ec44](af3ec44)) * edit pump-jack config ([36ad3d1](36ad3d1)) * fix validation pump-jack response ([71fa789](71fa789)) * remove validate token length for bypass ([8a0a332](8a0a332)) ### Features * add sender info to invitation email ([#502](#502)) ([d92e2b1](d92e2b1)) * added pump-jack account ([e1d34f1](e1d34f1))
Member
|
🎉 This PR is included in version 14.19.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the "Update invitation email template" feature request (slw-171)
In the gRPC proxy
senderIdshould be assigned automatically just like theorganizationIdConsider to use
senderIdas optional param instead of required inorganization.invites.sendschema