Merged
Conversation
annahassel
commented
Apr 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 87.27% 89.39% +2.12%
==========================================
Files 163 165 +2
Lines 3158 3216 +58
==========================================
+ Hits 2756 2875 +119
+ Misses 402 341 -61
Continue to review full report at Codecov.
|
AVVS
reviewed
Apr 5, 2021
Co-authored-by: Vitaly Aminev <AVVS@users.noreply.github.com>
annahassel
commented
Apr 9, 2021
annahassel
force-pushed
the
feat/apple-signin
branch
from
3a01c18 to
fbbb5f0
Compare
AVVS
reviewed
Jun 11, 2021
| }; | ||
| } | ||
| } catch (error) { | ||
| log.error({ error, message: 'Failed to parse user data from apple' }); |
AVVS
reviewed
Jun 11, 2021
Comment on lines
+101
to
+106
| if (isSameSite || isSameSite === false) { | ||
| // NOTE: this overwrites the default from bell | ||
| // must be specified, defaults to mf_bfb | ||
| server.states.cookies[rest.cookie].isSameSite = rest.isSameSite; | ||
| } | ||
| // @todo rest.isSameSite is undefined; why override? | ||
| // if (isSameSite || isSameSite === false) { | ||
| // // NOTE: this overwrites the default from bell | ||
| // // must be specified, defaults to mf_bfb | ||
| // server.states.cookies[rest.cookie].isSameSite = rest.isSameSite; | ||
| // } |
Member
There was a problem hiding this comment.
this wasnt getting set properly - mainly in test cases through chrome
AVVS
pushed a commit
that referenced
this pull request
Jun 15, 2021
# [14.20.0](v14.19.0...v14.20.0) (2021-06-15) ### Features * sign in with apple (web) ([#503](#503)) ([dd0969e](dd0969e))
Member
|
🎉 This PR is included in version 14.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.