Skip to content

fix: validate signature using raw body#567

Merged
pajgo merged 20 commits intomasterfrom
fix/validate-raw-payload-signature
Jul 15, 2022
Merged

fix: validate signature using raw body#567
pajgo merged 20 commits intomasterfrom
fix/validate-raw-payload-signature

Conversation

@pajgo
Copy link
Copy Markdown
Collaborator

@pajgo pajgo commented Jun 28, 2022

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2022

Codecov Report

Merging #567 (c08ca2c) into master (9362e4a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c08ca2c differs from pull request most recent head 715e211. Consider uploading reports for the commit 715e211 to get more accurate results

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   96.37%   96.36%   -0.01%     
==========================================
  Files         191      192       +1     
  Lines       11417    11447      +30     
==========================================
+ Hits        11003    11031      +28     
- Misses        414      416       +2     
Impacted Files Coverage Δ
src/actions/verify-request-signature.js 100.00% <100.00%> (ø)
src/auth/strategy.bearer.js 94.01% <100.00%> (-1.56%) ⬇️
src/configs/hapi.js 100.00% <100.00%> (ø)
src/utils/hapi-raw-request.js 100.00% <100.00%> (ø)
src/utils/signed-request.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34be06...715e211. Read the comment docs.

@pajgo pajgo force-pushed the fix/validate-raw-payload-signature branch from 67e07fe to eaf732d Compare June 28, 2022 15:58
Comment thread src/users.js
trustedVerify: 5000,
verifyRequestSignature: 5000,
apiTokenVerify: 5000,
tokenGet: 5000,
Copy link
Copy Markdown
Contributor

@bludzhd bludzhd Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to getToken (as the method key and their usage); or rename the method key and usage to tokenGet

@pajgo pajgo merged commit 16142ca into master Jul 15, 2022
@pajgo pajgo deleted the fix/validate-raw-payload-signature branch July 15, 2022 07:02
AVVS pushed a commit that referenced this pull request Jul 15, 2022
## [15.6.6](v15.6.5...v15.6.6) (2022-07-15)

### Bug Fixes

* **invite:** set accepted for existing users ([#571](#571)) ([8c454fe](8c454fe))
* validate signature using raw body ([#567](#567)) ([16142ca](16142ca))
@AVVS
Copy link
Copy Markdown
Member

AVVS commented Jul 15, 2022

🎉 This PR is included in version 15.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AVVS AVVS added the released label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants