corrected a typo, 404 error should be resolved #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

emilkovacev merged 1 commit into dev from 404fix

Sep 13, 2021

Contributor

russella26 commented Sep 13, 2021

hi emil :)


          corrected a typo, 404 error should be resolved

9f84ee2

Member

emilkovacev commented Sep 13, 2021

Next time leave a more descriptive pull request comment

emilkovacev approved these changes

View reviewed changes

emilkovacev merged commit 57d5b7c into dev

Contributor Author

russella26 commented Sep 13, 2021

awww
leaving a writeup for posterity
we forgot a return on line 22 of join/views.py so the code continued past when it should have returned the congrats for joining page, causing the 404 error

emilkovacev deleted the 404fix branch

September 13, 2021 20:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet