Skip to content

Proximity hot fix_issue44 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2020
Merged

Proximity hot fix_issue44 #45

merged 3 commits into from
Jun 22, 2020

Conversation

@kristinepetrosyan
Copy link
Contributor

@kristinepetrosyan kristinepetrosyan commented Jun 10, 2020

#44

@brendancol
Copy link
Contributor

brendancol commented Jun 15, 2020

@kristinepetrosyan Nice! small change

  • change xcord, ycord to just x='x' and y='y' in the proximity func sig (and update docstring / tests accordingly)

@brendancol brendancol merged commit 869728f into master Jun 22, 2020
@giancastro giancastro deleted the proximity_fix branch May 5, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kristinepetrosyan @brendancol