Fixed Integrations overview page and deleted Hypermode #354
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdates docs and styling: SVG icons in importers now use currentColor; integrations page capitalizes “GitHub” and uses a custom inline SVG via a new Card svg prop; Hyper Mode doc removed; dark-mode and card color rules adjusted in CSS; Vercel adds a redirect from a Hyper Mode anchor to root. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| }, | ||
| { | ||
| "source": "/performance/hyper-mode#use-hyper-mode", | ||
| "destination": "/" |
There was a problem hiding this comment.
Bug: Redirect Fails with URL Fragment
The new Vercel redirect's source includes a URL fragment (#use-hyper-mode). Since URL fragments are client-side only and not sent to the server, this redirect will never match. Users visiting the deleted /performance/hyper-mode page will therefore receive a 404 error.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/css/custom.css (1)
513-513: Consider reducing reliance on !important flags.The
!importantdeclarations on.card-description(line 513) and the dark-theme card text rules (lines 529-531) can make the stylesheet harder to maintain and override in the future.Consider using more specific selectors to achieve the desired specificity without
!important:.card-description { font-size: 14px; - color: #213547 !important; + color: #213547; } -[data-theme="dark"] .card-title, [data-theme="dark"] .card-description { - color: #fff !important; +[data-theme="dark"] .card .card-title, +[data-theme="dark"] .card .card-description { + color: #fff; }This approach maintains the same visual result while improving CSS maintainability.
Also applies to: 529-531
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/importers/overview.mdx(2 hunks)docs/integrations/about.mdx(2 hunks)docs/performance/hyper-mode.mdx(0 hunks)src/css/custom.css(3 hunks)vercel.json(1 hunks)
💤 Files with no reviewable changes (1)
- docs/performance/hyper-mode.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (5)
docs/importers/overview.mdx (1)
24-24: LGTM! Theme-aware SVG implementation.The change from hardcoded color values to
currentColorenables these SVG icons to inherit colors from CSS rules, supporting proper theme switching between light and dark modes. This aligns well with the CSS changes insrc/css/custom.cssthat define icon colors for different themes.Also applies to: 40-40, 45-45
docs/integrations/about.mdx (2)
11-11: LGTM! Correct brand capitalization.Properly capitalizes "GitHub" according to the official brand guidelines.
24-37: LGTM! Consistent SVG theming pattern.The Sentry card now uses the
svgprop with an inline SVG, following the samecurrentColorpattern established in the importers page. This ensures consistent theme-aware icon rendering across the documentation.src/css/custom.css (2)
492-492: LGTM! Consistent icon theming.Adding the primary color to
.card-iconensures consistency with the overall theme and works well with thecurrentColorpattern in the SVG implementations.
499-501: LGTM! Good selector consolidation.Combining
.icon-styleand.card-iconin a single dark-theme rule reduces duplication and ensures consistent icon coloring across both classes.
| { | ||
| "source": "/performance/hyper-mode#use-hyper-mode", | ||
| "destination": "/" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
Verify that fragment-based redirects work as expected.
The redirect includes a fragment identifier (#use-hyper-mode) in the source path. Fragment identifiers are typically handled client-side and may not always be sent to the server, which could prevent this redirect from matching incoming requests in some browsers or contexts.
Run the following script to check if there are other fragment-based redirects in the configuration and to verify Vercel's documentation on fragment support:
You may also want to search the web for Vercel's official documentation on fragment/anchor redirect support:
🏁 Script executed:
#!/bin/bash
# Check for other fragment-based redirects in vercel.json
echo "=== Checking for other fragment-based redirects in vercel.json ==="
rg -n '#' vercel.json
echo -e "\n=== Recommendation ==="
echo "Consider adding a redirect without the fragment as well:"
echo ' { "source": "/performance/hyper-mode", "destination": "/" }'Length of output: 271
🌐 Web query:
Does Vercel support URL fragment identifiers in redirect source paths?
💡 Result:
Short answer: No — you cannot match a URL fragment (the part after #) in a Vercel redirect source because browsers never send the fragment to the server. Vercel's redirect rules match the incoming pathname (and query) on the server/edge, so fragments can't be used in a source pattern. You can, however, include a fragment in a redirect destination/Location if you need the browser to end up at a particular fragment. [1][2][3]
Sources:
- Vercel redirects docs (redirects match incoming pathname; configure source/destination). [1]
- MDN: URL/hash (fragment identifiers are client-side; browser exposes them to JS but does not send them in requests). [2]
- RFC 7231: fragment identifiers are not sent in requests; redirects may inherit or include fragments in Location. [3]
Fix fragment-based redirect
Vercel’s redirect rules match only the URL pathname; fragments (#…) are never sent to the server. The rule
{ "source": "/performance/hyper-mode#use-hyper-mode", "destination": "/" }will never match. Replace it with a path-only source, for example:
{ "source": "/performance/hyper-mode", "destination": "/#use-hyper-mode" }–or, if you simply want to redirect to the homepage, use:
{ "source": "/performance/hyper-mode", "destination": "/" }This ensures the redirect will match and land on the intended location.
🤖 Prompt for AI Agents
In vercel.json around lines 233 to 236, the redirect uses a URL fragment in the
"source" ("/performance/hyper-mode#use-hyper-mode") which will never match
because fragments are client-side only; change the rule to use a path-only
source "/performance/hyper-mode" and move the fragment to the "destination" as
"/#use-hyper-mode" if you want to land on the anchor, or simply set
"destination" to "/" if you only want to redirect to the homepage.
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Note
Refresh integrations/importers docs with icon theming updates, remove the Hyper Mode page, tweak card/icon styles, and add a redirect for the retired page.
GitHub; enhanceSentrycard with inline SVG icon.LinearandAsanaSVGs to inheritcurrentColorfor theme consistency.docs/performance/hyper-mode.mdx..card-iconcolor and include in dark theme selector; improve.card-descriptioncolor and add dark-mode overrides for.card-title/.card-description.vercel.jsonfrom/performance/hyper-mode#use-hyper-modeto/.Written by Cursor Bugbot for commit d28c92c. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
Documentation
Style