-
Notifications
You must be signed in to change notification settings - Fork 1
SDK was refactored to support the execution of unit test cases #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juan-malbeclabs
merged 19 commits into
main
from
feature/211-refactor-the-rust-sdk-to-support-testing-for-each-smart-contract-call
Apr 25, 2025
Merged
SDK was refactored to support the execution of unit test cases #215
juan-malbeclabs
merged 19 commits into
main
from
feature/211-refactor-the-rust-sdk-to-support-testing-for-each-smart-contract-call
Apr 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking it easier to validate individual components and ensure correctness during development. This change improves testability and facilitates more reliable and maintainable code.
…, and User. This includes the deletion of associated traits and methods, streamlining the codebase by eliminating unused functionality.
…ct workspace to centralize the code. The CLI will only be responsible for building the command structure and invoking the corresponding logic. This approach ensures that all logic resides in a single place, where unit tests can also be executed.
…ng command logic located in the smartcontract folder. This approach ensures that both CLI interfaces rely on a shared and centralized codebase.
…g to minor changes based on linter suggestions.
elitegreg
requested changes
Apr 23, 2025
|
Need to check out e2e failure too |
bgm-malbeclabs
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments and I've yet to ingest the context but the reorganization makes sense to me
…across multiple files for consistency and clarity. Update Cargo.toml and Cargo.lock to reflect changes in package naming and dependencies.
…and patterns used across the rest of the command set.
- Updated all instances of `double_zero_sla_program` to `doublezero_sla_program` across multiple files for consistency. - Cleaned up code formatting and removed unnecessary line breaks. - Adjusted transaction execution patterns for better readability. - Modified the `delete` command to include a read-only account meta for `globalstate_pubkey`. - Ensured all command modules are correctly listed in their respective `mod.rs` files.
…es and restructure service controller implementation
elitegreg
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the SDK to enable generating test cases for each command.