Skip to content

Conversation

@juan-malbeclabs
Copy link
Contributor

Refactor the SDK to enable generating test cases for each command.

…aking it easier to validate individual components and ensure correctness during development. This change improves testability and facilitates more reliable and maintainable code.
juanolv added 4 commits April 22, 2025 21:08
…, and User. This includes the deletion of associated traits and methods, streamlining the codebase by eliminating unused functionality.
…ct workspace to centralize the code. The CLI will only be responsible for building the command structure and invoking the corresponding logic. This approach ensures that all logic resides in a single place, where unit tests can also be executed.
…ng command logic located in the smartcontract folder. This approach ensures that both CLI interfaces rely on a shared and centralized codebase.
…g to minor changes based on linter suggestions.
@elitegreg
Copy link
Contributor

Need to check out e2e failure too

Copy link
Contributor

@bgm-malbeclabs bgm-malbeclabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments and I've yet to ingest the context but the reorganization makes sense to me

juanolv added 11 commits April 23, 2025 18:55
…across multiple files for consistency and clarity. Update Cargo.toml and Cargo.lock to reflect changes in package naming and dependencies.
…and patterns used across the rest of the command set.
- Updated all instances of `double_zero_sla_program` to `doublezero_sla_program` across multiple files for consistency.
- Cleaned up code formatting and removed unnecessary line breaks.
- Adjusted transaction execution patterns for better readability.
- Modified the `delete` command to include a read-only account meta for `globalstate_pubkey`.
- Ensured all command modules are correctly listed in their respective `mod.rs` files.
…es and restructure service controller implementation
@juan-malbeclabs juan-malbeclabs merged commit 4ba0240 into main Apr 25, 2025
9 checks passed
@juan-malbeclabs juan-malbeclabs deleted the feature/211-refactor-the-rust-sdk-to-support-testing-for-each-smart-contract-call branch April 25, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the Rust SDK to support testing for each smart contract call

5 participants