#145 - add bgp session status to client #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgm-malbeclabs
commented
Apr 24, 2025
bgm-malbeclabs
commented
Apr 24, 2025
bgm-malbeclabs
force-pushed
the
dz_status_session_info
branch
from
a16802c to
8720a09
Compare
packethog
requested changes
Apr 25, 2025
bgm-malbeclabs
force-pushed
the
dz_status_session_info
branch
from
8720a09 to
7e0a688
Compare
packethog
requested changes
Apr 25, 2025
bgm-malbeclabs
force-pushed
the
dz_status_session_info
branch
from
d8b60ed to
2ce6dc2
Compare
packethog
approved these changes
Apr 25, 2025
bgm-malbeclabs
force-pushed
the
dz_status_session_info
branch
from
2ce6dc2 to
dbdc47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
This PR adds bgp session status changes to the doubelzerod and is accessible through the cli with
doublezero status. The session type is held in memory and changes when the corebgp update handler gets a new message. The handle update conditions are described here The session types are:There's also a timestamp that is updated on session type update.
E2E test fixtures will be updated in #220 to allow for dynamic values and should make the tests less brittle. Adding it in a subsequent PR to keep this PR small and the timestamp isn't used yet.
This also fixes a type
resposetoresponsein the service controller module.Evidence of Testing