-
Notifications
You must be signed in to change notification settings - Fork 1
smartcontract: fix typo for SEED_MULTICAST_GROUP #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects a typo in the SEED_MULTICAST_GROUP constant and adjusts corresponding CLI test fixtures.
- Fix typo in the seed constant value.
- Update expected account public keys in
get.rstests.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| smartcontract/programs/doublezero-serviceability/src/seeds.rs | Corrected SEED_MULTICAST_GROUP byte string. |
| smartcontract/cli/src/multicastgroup/get.rs | Updated hard-coded expected account keys in tests. |
02fbf72 to
e9cea4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Just to clarify, this will effectively invalidate any previously saved multicast groups? We only have 1 in the testnet that we created yesterday ( |
I think so, @juan-malbeclabs can you answer this question? I suppose this fix will indeed invalidate existing mcast groups, so we need to think about whether including this change effectively means redeploying on testnet. |
Summary
Fix #637
Fixes a typo I noticed for
SEED_MULTICAST_GROUP