Skip to content

Conversation

@vihu
Copy link
Contributor

@vihu vihu commented Jun 23, 2025

Summary

Fix #637

Fixes a typo I noticed for SEED_MULTICAST_GROUP

@vihu vihu requested a review from Copilot June 23, 2025 20:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a typo in the SEED_MULTICAST_GROUP constant and adjusts corresponding CLI test fixtures.

  • Fix typo in the seed constant value.
  • Update expected account public keys in get.rs tests.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
smartcontract/programs/doublezero-serviceability/src/seeds.rs Corrected SEED_MULTICAST_GROUP byte string.
smartcontract/cli/src/multicastgroup/get.rs Updated hard-coded expected account keys in tests.

@vihu vihu force-pushed the rg/fixup-typo branch 2 times, most recently from 02fbf72 to e9cea4f Compare June 23, 2025 21:16
@vihu vihu requested review from bgm-malbeclabs and snormore June 23, 2025 21:23
Copy link
Contributor

@juan-malbeclabs juan-malbeclabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snormore
Copy link
Contributor

snormore commented Jun 24, 2025

Just to clarify, this will effectively invalidate any previously saved multicast groups?

We only have 1 in the testnet that we created yesterday (mg01), so it's not unreasonable to do, just want to make sure I understand the side effects of the change.

@vihu
Copy link
Contributor Author

vihu commented Jun 24, 2025

Just to clarify, this will effectively invalidate any previously saved multicast groups?

We only have 1 in the testnet that we created yesterday (mg01), so it's not unreasonable to do, just want to make sure I understand the side effects of the change.

I think so, @juan-malbeclabs can you answer this question? I suppose this fix will indeed invalidate existing mcast groups, so we need to think about whether including this change effectively means redeploying on testnet.

@vihu vihu merged commit 6547667 into main Jun 26, 2025
11 checks passed
@vihu vihu deleted the rg/fixup-typo branch June 26, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smartcontract: fix typo for SEED_MULTICAST_GROUP

5 participants