Skip to content

Conversation

Hill-98
Copy link
Contributor

@Hill-98 Hill-98 commented Dec 1, 2023

#6

@Hill-98 Hill-98 force-pushed the add-options branch 2 times, most recently from 86017bf to 59fdef1 Compare December 1, 2023 10:38
@Hill-98
Copy link
Contributor Author

Hill-98 commented Dec 3, 2023

@mame I made some modifications to repeater.ps1, but I have a new version of OpenSSH installed locally and cannot effectively test it. Can you test whether it handles extended messages correctly?

@mame
Copy link
Owner

mame commented Dec 4, 2023

Thanks, but it did not work. Looks like $buf is Null. I have no time to debug it now. Sorry.

$ ./wsl2-ssh-agent -foreground -verbose | nkf -u -Sw
[L] 2023/12/02 18:47:20 start listening on /home/mame/.ssh/wsl2-ssh-agent.sock
[L] 2023/12/02 18:47:20 invoking [W] in PowerShell.exe
[W] 2023/12/04 11:16:31 ssh-agent.exe version: 8.6.0.1 (ignoreOpenSSHExtensions: True)
[W] 2023/12/04 11:16:31 ready: PSVersion 5.1.22621.2506
[L] 2023/12/02 18:47:21 [W] invoked successfully
[L] 2023/12/02 18:47:23 ssh: connected
[L] 2023/12/02 18:47:23 ssh -> [L] (212 B)
[L] 2023/12/02 18:47:23 [L] -> [W] (212 B)
[W] 2023/12/04 11:16:32 [W] named pipe: connected
[W] 2023/12/04 11:16:33 [L] -> [W] -> ssh-agent.exe (212 B)
[W] 2023/12/04 11:16:33 [L] <- [W] <- ssh-agent.exe (0 B)
[W] 2023/12/04 11:16:33 [W] named pipe: disconnected
wsl2-ssh-agent.ps1: terminated
"3" 個の引数を指定して "Write" を呼び出し中に例外が発生しました: "値を Null にすることはできません。
パラメーター名:buffer"
発生場所 行:35 文字:5
+                 $ssh_client_out.Write($buf, 0, $buf.Length)
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentNullException

@mame
Copy link
Owner

mame commented Dec 4, 2023

Also, to make my review easier, it would be nice if you could please not include irrelevant changes, or at least separate commits.

@Hill-98 Hill-98 force-pushed the add-options branch 2 times, most recently from 299b063 to ace0450 Compare December 4, 2023 10:49
@Hill-98 Hill-98 changed the title Add options for custom exe paths and extension messages Reimplement repeater.ps1 Dec 4, 2023
@Hill-98
Copy link
Contributor Author

Hill-98 commented Dec 4, 2023

Fixed the above issue, and I tested it successfully on OpenSSH 8.6.

Copy link
Owner

@mame mame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It worked great on my machine. I have added some minor comments, but it's ok for me to fix them after the merge. Which do you prefer?

repeater.ps1 is now used for ssh-agent.exe version checking and OpenSSH extended message filtering
@Hill-98
Copy link
Contributor Author

Hill-98 commented Dec 9, 2023

@mame Do you have any other comments? If not, can it be merged?

@mame mame merged commit c01e7e3 into mame:main Dec 9, 2023
@mame
Copy link
Owner

mame commented Dec 9, 2023

Yeah, merged. Thanks!

@mame
Copy link
Owner

mame commented Dec 9, 2023

Ah, go test fails. I didn't set up GitHub Actions...

@Hill-98
Copy link
Contributor Author

Hill-98 commented Dec 9, 2023

Looks like I forgot to modify the test.

mame added a commit that referenced this pull request Dec 9, 2023
Follow up of #7
mame added a commit that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants