-
Notifications
You must be signed in to change notification settings - Fork 11
Reimplement repeater.ps1 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86017bf
to
59fdef1
Compare
@mame I made some modifications to repeater.ps1, but I have a new version of OpenSSH installed locally and cannot effectively test it. Can you test whether it handles extended messages correctly? |
Thanks, but it did not work. Looks like
|
Also, to make my review easier, it would be nice if you could please not include irrelevant changes, or at least separate commits. |
299b063
to
ace0450
Compare
Fixed the above issue, and I tested it successfully on OpenSSH 8.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It worked great on my machine. I have added some minor comments, but it's ok for me to fix them after the merge. Which do you prefer?
repeater.ps1 is now used for ssh-agent.exe version checking and OpenSSH extended message filtering
@mame Do you have any other comments? If not, can it be merged? |
Yeah, merged. Thanks! |
Ah, |
Looks like I forgot to modify the test. |
#6