fixing cron conversion #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM. Please rebase and add to the CHANGELOG :) |
jonbannister
approved these changes
Jun 2, 2023
added 2 commits
July 10, 2023 14:46
marcinapostoluk
force-pushed
the
135-fix-cron-schedule-on-save
branch
from
2ffc485 to
e5a141f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago a change was made to convert between crontab and apscheduler days of week - cadba46#diff-490c71dda64b8e9aab6c585e5cab2133d798ff6b14f792dcf85ca667aa69be90
However that conversion was done only one way and each time ones saves the schedule the conversion happens shifting the days incorrectly.
A fix is to shift the days back to the crontab format when presenting to the UI