#13 Support database plugins / rework of entrypoints #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-specific entrypoints. TODO: Fix tests, use env vars as default
jonbannister
force-pushed
the
database-plugins
branch
from
c35c38f to
37b85c4
Compare
aflag
reviewed
Dec 3, 2020
aflag
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry points have improved from command-line/env var mix to solely command line input
MONGO_HOST=dev PORT=11828 notebooker_webapp->notebooker_cli --mongo-host dev start-webapp --port 11828execute_notebook->notebooker_cli execute-notebookThese should now work a lot more consistently, and have no reliance on magic environment variables.
Also added a 3.7 test bed
Tutorial to add a plugin will be forthcoming.