Update mdtopdf.go#24
Merged
Merged
Conversation
Looks like Code styling declaration is missed ... sorry about that, Can u please approved and merged ... thanks
mandolyte
approved these changes
Mar 15, 2023
Collaborator
|
@prasannahanu done! |
Contributor
Author
|
Are latest pull requests not merged to v1.3.0 version ? Need to merge pull requests #23 and #24 into latest v1.3.0 release ... thx
When I get latest version, I am still seeing old code and giving error
since latest updates are missing
go: github.com/mandolyte/mdtopdf upgrade => v1.3.0
# github.com/mandolyte/mdtopdf
/Users/prasanna/code/go/pkg/mod/
***@***.***/nodeProcessing.go:32:33: syntax error:
unexpected r, expecting comma or )
/Users/prasanna/code/go/pkg/mod/
***@***.***/nodeProcessing.go:234:33: syntax error:
unexpected r, expecting comma or )
…On Tue, Mar 14, 2023 at 9:32 PM Cecil New ***@***.***> wrote:
@prasannahanu <https://github.com/prasannahanu> done!
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5SAHSGXGTXS7ZXZWPJWIT3W4EL27ANCNFSM6AAAAAAV2SSDRM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
Thanks, I forgot to do a new release... there is now a patch release v1.3.1
Cecil
On Thu, Mar 16, 2023 at 10:59 AM prasannahanu ***@***.***>
wrote:
… Are latest pull requests not merged to v1.3.0 version ?
When I get latest version, I am still seeing old code and giving error
since latest updates are missing
go: github.com/mandolyte/mdtopdf upgrade => v1.3.0
# github.com/mandolyte/mdtopdf
/Users/prasanna/code/go/pkg/mod/
***@***.***/nodeProcessing.go:32:33: syntax error:
unexpected r, expecting comma or )
/Users/prasanna/code/go/pkg/mod/
***@***.***/nodeProcessing.go:234:33: syntax error:
unexpected r, expecting comma or )
On Tue, Mar 14, 2023 at 9:32 PM Cecil New ***@***.***> wrote:
> @prasannahanu <https://github.com/prasannahanu> done!
>
> —
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A5SAHSGXGTXS7ZXZWPJWIT3W4EL27ANCNFSM6AAAAAAV2SSDRM
>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ2ZXMRPPJKZGEJEUI36ZLW4MTGVANCNFSM6AAAAAAV2SSDRM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Code styling declaration is missed ... sorry about that, Can u please approved and merged ... thanks