Use temporal-shaded to avoid protobuf version mismatch #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
3 times, most recently
from
cdb5c9f to
07b3161
Compare
Contributor
|
@FelipeCortez could you add a link to the upstream PR that is blocking this one? |
Contributor
Author
The PR got merged last month. I was waiting for the new SDK version release so we're able to pick up the change, and it seems like it finally happened last Friday. Updating the project.clj to test this out. |
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
from
07b3161 to
a30a594
Compare
Contributor
Author
|
@ghaskins seems like tests are passing now, but I had to resolve a merge conflict and need a new review. |
Contributor
|
@FelipeCortez it still seems to need a rebase |
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
2 times, most recently
from
ad6f1a2 to
7e0d181
Compare
Signed-off-by: Felipe Cortez <github@felipecortez.net>
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
from
7e0d181 to
5e2b58b
Compare
Contributor
Author
sorry about that! I'm used to keeping the merge commits. should be good now |
ghaskins
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cljdoc API import seems to have been failing since 1.3.0 because of a protobuf version mismatch. This PR switches the Temporal Java SDK to the shaded version. Analysis was tested locally with
clojure -Ttools install io.github.cljdoc/cljdoc-analyzer '{:git/tag "RELEASE"}' :as cljdoc && lein jar && lein pom && clojure -Tcljdoc analyze-localand ran successfully after the change.