Skip to content

Conversation

@manghidev
Copy link
Owner

This pull request introduces several enhancements to the LazyVim Docker environment, including new commands in the Makefile, a version update, improved configuration options, and the addition of a comprehensive configuration script. The most significant changes focus on improving usability and flexibility for managing the Docker environment.

Makefile Enhancements:

  • Added new commands to the .PHONY list, including install-global, uninstall, remote-install, remote-uninstall, and configure, for easier management of global and remote installations as well as reconfiguration.
  • Introduced the configure target to reconfigure directories and timezone using the new script scripts/configure.sh.
  • Added commands for testing remote installation scripts (test-remote-scripts) and provided instructions for remote installation through install-remote.

New Configuration Script:

  • Added scripts/configure.sh, a detailed script to reconfigure timezone and directory mounts. It includes user prompts, validation, and updates to docker-compose.yml based on user input.

Configuration Improvements:

  • Updated docker-compose.yml to simplify volume mount comments and remove unused configurations, making it easier to customize directory mounts. [1] [2]

Version and Documentation Updates:

  • Updated the VERSION file to reflect the new version 1.3.0.
  • Removed the outdated docs/CHANGELOG.md file, likely in preparation for a new changelog format or location.

Miscellaneous:

  • Updated .dockerignore to ignore all files by default, potentially to streamline Docker builds.

@manghidev manghidev self-assigned this Jul 1, 2025
@manghidev manghidev requested a review from Copilot July 1, 2025 04:39

This comment was marked as outdated.

manghidev and others added 2 commits June 30, 2025 22:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@manghidev manghidev requested a review from Copilot July 1, 2025 04:47

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@manghidev manghidev requested a review from Copilot July 1, 2025 05:08

This comment was marked as outdated.

@manghidev manghidev requested a review from Copilot July 1, 2025 05:10

This comment was marked as outdated.

@manghidev manghidev requested a review from Copilot July 1, 2025 05:13

This comment was marked as resolved.

@manghidev manghidev merged commit 6f95063 into main Jul 1, 2025
@manghidev manghidev requested review from Copilot and removed request for Copilot July 1, 2025 05:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for remote installation and uninstallation of LazyVim Docker, extends the Makefile with new commands, introduces a comprehensive configuration script, updates versioning, and streamlines Docker context with a new .dockerignore.

  • Added remote-install, remote-uninstall, remote-update, install-global, uninstall, and configure commands in the Makefile
  • Introduced new scripts under scripts/ for remote install/update/uninstall, global command management, and reconfiguration
  • Updated docker-compose.yml, bumped VERSION to 1.3.0, removed outdated changelog, and tightened build context with .dockerignore

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Makefile Added PHONY targets for remote/global commands and configure
.dockerignore Now ignores all files by default
scripts/uninstall-global-commands.sh New script to remove global commands and optionally project dir
scripts/remote-install.sh New one-line installer
scripts/remote-uninstall.sh New one-line uninstaller
scripts/remote-update.sh New one-line updater
scripts/install-global-commands.sh New installer for global lazy commands
scripts/configure.sh New script to reconfigure timezone and directory mounts
docker-compose.yml Simplified volume mount comments
VERSION Bumped version to 1.3.0
docs/CHANGELOG.md Removed outdated changelog
Comments suppressed due to low confidence (1)

scripts/uninstall-global-commands.sh:61

  • [nitpick] Using sed -i.tmp creates a backup file with .tmp suffix that’s never cleaned up. Consider using sed -i without a backup or explicitly remove the .tmp file after the operation.
    if sed -i.tmp "/$START_MARKER/,/$END_MARKER/d" "$config_file" 2>/dev/null; then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants