-
Notifications
You must be signed in to change notification settings - Fork 0
Remote installation #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…zone, update related commands in Makefile and scripts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for remote installation and uninstallation of LazyVim Docker, extends the Makefile with new commands, introduces a comprehensive configuration script, updates versioning, and streamlines Docker context with a new .dockerignore.
- Added
remote-install,remote-uninstall,remote-update,install-global,uninstall, andconfigurecommands in the Makefile - Introduced new scripts under
scripts/for remote install/update/uninstall, global command management, and reconfiguration - Updated
docker-compose.yml, bumpedVERSIONto 1.3.0, removed outdated changelog, and tightened build context with.dockerignore
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Added PHONY targets for remote/global commands and configure |
| .dockerignore | Now ignores all files by default |
| scripts/uninstall-global-commands.sh | New script to remove global commands and optionally project dir |
| scripts/remote-install.sh | New one-line installer |
| scripts/remote-uninstall.sh | New one-line uninstaller |
| scripts/remote-update.sh | New one-line updater |
| scripts/install-global-commands.sh | New installer for global lazy commands |
| scripts/configure.sh | New script to reconfigure timezone and directory mounts |
| docker-compose.yml | Simplified volume mount comments |
| VERSION | Bumped version to 1.3.0 |
| docs/CHANGELOG.md | Removed outdated changelog |
Comments suppressed due to low confidence (1)
scripts/uninstall-global-commands.sh:61
- [nitpick] Using
sed -i.tmpcreates a backup file with.tmpsuffix that’s never cleaned up. Consider usingsed -iwithout a backup or explicitly remove the.tmpfile after the operation.
if sed -i.tmp "/$START_MARKER/,/$END_MARKER/d" "$config_file" 2>/dev/null; then
This pull request introduces several enhancements to the LazyVim Docker environment, including new commands in the
Makefile, a version update, improved configuration options, and the addition of a comprehensive configuration script. The most significant changes focus on improving usability and flexibility for managing the Docker environment.Makefile Enhancements:
.PHONYlist, includinginstall-global,uninstall,remote-install,remote-uninstall, andconfigure, for easier management of global and remote installations as well as reconfiguration.configuretarget to reconfigure directories and timezone using the new scriptscripts/configure.sh.test-remote-scripts) and provided instructions for remote installation throughinstall-remote.New Configuration Script:
scripts/configure.sh, a detailed script to reconfigure timezone and directory mounts. It includes user prompts, validation, and updates todocker-compose.ymlbased on user input.Configuration Improvements:
docker-compose.ymlto simplify volume mount comments and remove unused configurations, making it easier to customize directory mounts. [1] [2]Version and Documentation Updates:
VERSIONfile to reflect the new version1.3.0.docs/CHANGELOG.mdfile, likely in preparation for a new changelog format or location.Miscellaneous:
.dockerignoreto ignore all files by default, potentially to streamline Docker builds.