Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 14, 2020

Close #41

  • Add attributes to rendered tags that are missing them

@ghost ghost marked this pull request as draft May 14, 2020 02:55
@ghost
Copy link
Author

ghost commented May 14, 2020

I'm thinking the DOM handler is easier to serialise. It would also permit other XML types to be serialised appropriately.

EDIT: In fact, the DOM handler also doesn't rearrange text nodes interwoven with XML children, making it much less destructive

@manoelcampos
Copy link
Owner

manoelcampos commented Jun 2, 2020

Hello @lmn8
Sorry for the late reply, but I'm really busy these days.
Are you planning to fix the other items?
Because those would be new issues.

If you are done already, I'll try the code for merging.
I checked quickly and seems to be OK.

Thanks for contributing.

@ghost ghost marked this pull request as ready for review June 2, 2020 21:00
@ghost
Copy link
Author

ghost commented Jun 2, 2020

You can merge it. The other issues (CDATA, text node rendering) are going to require handler changes too, so you would need to bump the version.

At some point, I can open a pull that will allow serialising DOM handler roots.

manoelcampos added a commit that referenced this pull request Jun 3, 2020
Merge branch 'lmn8-master' into dev
@manoelcampos manoelcampos self-requested a review June 3, 2020 13:28
@manoelcampos manoelcampos assigned manoelcampos and ghost and unassigned manoelcampos Jun 3, 2020
@manoelcampos manoelcampos merged commit 89376e5 into manoelcampos:master Jun 3, 2020
@ghost ghost changed the title Improve serialiser handling of attributes, text nodes Improve serialiser handling of attributes Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialiser is good but has shortcomings

1 participant