Skip to content

Conversation

@manq2010
Copy link
Owner

Awesome books: a complete website with navigation

In this release, the following was done:

  • Created a Navigation bar.
  • Displays available books on the DOM

Copy link

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manq2010 @Enning94 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • All navigation links work fine 👍
  • Proper use of Github folw 👍
  • Well written PR description 👍
  • No linter errors 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@manq2010 manq2010 merged commit 08eb4e6 into master Oct 26, 2022
@krisbobo krisbobo mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants