HDBSCAN clustering method added for Bragg peaks inferred from DL model #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warunawickramasingha
changed the title
RichardWaiteSTFC
requested changes
Dec 18, 2024
Contributor
RichardWaiteSTFC
left a comment
RichardWaiteSTFC
left a comment
There was a problem hiding this comment.
Thanks for this, I think while the HDBSCAN is not performing as well as the QLab merging we keep the latter as the default.
Is there any reason to offer the user KMeans? Does it offer any advantage over the other methods?
warunawickramasingha
force-pushed
the
38269_peak_clustering
branch
from
741df7b to
23898fe
Compare
RichardWaiteSTFC
requested changes
Jan 2, 2025
Contributor
RichardWaiteSTFC
left a comment
RichardWaiteSTFC
left a comment
There was a problem hiding this comment.
Looks good thanks, just a couple of minor doc updates!
warunawickramasingha
force-pushed
the
38269_peak_clustering
branch
from
f70e561 to
593cb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HDBSCAN clustering method as a post processing step for the Braggs peaks inferred from the DL model.