-
Notifications
You must be signed in to change notification settings - Fork 14
Add information about version of PHP 7.1 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for master and version 2.1.x
|
@Kirill , I really have not tested this with PHP 5.6. Are we positive the new version does not work with it? Do you think we should look into making it compatible? Or should we just drop off and let users stay with the older versions and encourage them to migrate to PHP 7+? |
|
I will be doing some testing soon on this. Thanks for the PR. |
|
I can't test it for older version. I look on README. |
|
Also, as per the guide, please try to make your changes on develop or feat branches rather than on your fork's master, because then you will have a hard time keeping your fork's master updated from the main master. It goes like this: |
|
I see what you mean about the BBCode parser being only for PHP 7.1+. Hmmm...yeah, then I guess we need to stay with 7.1+ and tell users that BBCode 2.1.x requires PHP 7.1+. PHP 5.6 is EOL already, the security fixes stopped Jan 1, 2019 (according to PHP.net). |
|
|
I will test older PHP soon. It might not be as bad. We'll see. The parsers are really simple. |
|
I think the author is requiring PHP 7.1 +, because hIs libraries are primarily designed to work in a Laravel environment. But they can also be used as a standalone classes. |
|
So, I found that it was indeed incompatible with PHP 5.6. I have made modifications to the parser class, and now it is compatible with PHP 5.6. I will test with PHP 5.5.9 to make sure. If it all works, if you don't mind, I will go ahead and close this PR. I will also post a better Git graphic to the guide explaining the development and PR model. I am sorry the "diagram" I made here is not very good. |
|
@Kirill, I can confirm that the changes I have made to the parser classes work on PHP 5.5.9+. I will go ahead and close this PR and send the changes in another PR. As I said before, let's get in the habit of not accepting PRs that come from a fork's master branch so as to avoid regressions and commit conflicts. I will try to clarify this in the guide more. After I merge the PR, please fetch the latest upstream into your fork's master add then do a full |
|
Fixes for compatibility have been applied on PR #43. This PR is now closed. |
for master and version 2.1.x