Use REST API instead of xmlhttprequest [CANCELLED] #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simpletip javascript library that has been used until now to provide contextual help for Snippets placeholders is no longer maintained (since 2009), and has been superseded by qTip2 [1]. This commit removes the old library, adds the latest version of qTip2 and implements the following changes in the code to support it: - Change display from a floating tooltip to a fixed position on the top right of the textarea - Modify the format of the JSON returned by the *pattern_help* XHR to an array [title, help text] - Update language strings for the new help format - Adjust CSS for correct display; in particular, the ace-mantis.css forces a white background for <table> so we need to override that Fixes mantisbt-plugins#25 Fixes mantisbt-plugins#19 [1]: https://qtip2.com
XHR was deprecated in Mantis 2.3.0.
Publish 3 REST API endpoints to replace the corresponding XHR functions:
- xmlhttprequest_plugin_snippets_data
=> ./plugins/Snippets/list and ./plugins/Snippets/list/{bug_id}
- xmlhttprequest_plugin_snippets_help
=> ./plugins/Snippets/help
Fixes mantisbt-plugins#16
|
@vboctor Many thanks for taking the time to review. I've responded to your comments, let me know |
Following @vboctor's recommendation in the PR's discussion: > We may want to have the API extensibility infrastructure do the > plugin_push_current() call so that each plugin doesn't have to worry > about this. We can have a middle where that matches against paths > under plugin_route_group() and pushes the base name. In preparation > for that, it may be useful just to have one line for a push rather > than having N places references base name
This was introduced in v0.3 (f2b7f23), but the version information was never actually used in the javascript. Fixes mantisbt-plugins#27
|
Something's wrong with this PR, it contains an unrelated commit and I can't seem to fix it. |
dregad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a pull request to make the review process easier.
Fixes #16