Skip to content

better error msg when commit url is not accessible #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

better error msg when commit url is not accessible #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3344661
better error msg when commit url is not accessible
davewood Feb 10, 2016
e8c9f10
simpler check for truth of $t_commit_url data
davewood Feb 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions SourceGitweb/SourceGitweb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,11 @@ private function import_commits( $p_repo, $p_uri_base, $p_commit_ids, $p_branch=
$t_commit_url = $this->uri_base( $p_repo ) . 'a=commit;h=' . $t_fixed_id;
$t_input = url_get( $t_commit_url );

if ( false === $t_input ) {
echo "failed.\n";
echo "$t_commit_url\n"; # DEBUG
continue;
}
if ( !$t_input ) {
echo "failed.\nno input found.\n";
echo "The data returned from accessing \"$t_commit_url\" returned a FALSE value.\n";
die();
}

list( $t_changeset, $t_commit_parents ) = $this->commit_changeset( $p_repo, $t_input, $p_branch );
if ( !is_null( $t_changeset ) ) {
Expand All @@ -254,7 +254,7 @@ private function commit_changeset( $p_repo, $p_input, $p_branch='' ) {
$t_input_p1 = strpos( $t_input, '<div class="title_text">' );
$t_input_p2 = strpos( $t_input, '<div class="list_head">' );
if ( false === $t_input_p1 || false === $t_input_p2 ) {
echo 'commit data failure.';
echo "commit data failure.\n";
var_dump( strlen( $t_input ), $t_input_p1, $t_input_p2 );
die();
}
Expand Down