Hide edit controls on changeset details page for unauthorized users #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has sufficient privileges at least in one project he is allowed to see "Attach", "Detach", and "Edit" buttons for any changeset on Details page (Source/view&id=<changeset_id>). For example if Source plugin settings are: View Threshold: viewer, Update Threshold: developer And the user rights are: Global: viewer, Some project: developer The user will see those buttons for any changeset (attached to any bug of any project, or not attached at all), if he change the current project to Some project in drop-down list. This would look like a security issue, but these buttons do not actually work, because all actions are checked for global permissions afterwards. This commit fixes the issue described above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has sufficient privileges at least in one project he is allowed to see "Attach", "Detach", and "Edit" buttons for any changeset on Details page (Source/view&id=<changeset_id>).
For example if Source plugin settings are: View Threshold: viewer, Update Threshold: developer
And the user rights are: Global: viewer, Some project: developer
The user will see those buttons for any changeset (attached to any bug of any project, or not attached at all), if he change the current project to Some project in drop-down list.
This would look like a security issue, but these buttons do not actually work, because all actions are checked for global permissions afterwards.
This commit fixes the issue described above.