Improved handling of changesets on list page #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If there are no issues linked to the changeset, display an input field and button to allow the user to add links without having to open the changeset view page.
Use changeset's revision id as anchor in the changesets list, and use that as a new 'redirect' parameter for the attach page so it returns straight to the changeset list's row that called it. If the new param is not specified, the behavior is as it was before, i.e. redirect to view page.
Member
Author
|
This PR introduced a regression in View Issue page's Related Changesets section - see #231. |
dregad
added a commit
that referenced
this pull request
Sep 14, 2017
When viewing an issue's Related Changesets (in view.php), an error message 'String "plugin_SourceIntegration_affected_issues" not found.' is displayed. This is because the plugin context in View Issue page is not 'Source', but 'SourceIntegration', so the plugin_lang_get() call needs to reference the base plugin. Regression introduced by 5aec110 (#224) Fixes #231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
@luzpaz testing and feedback would be appreciated.