Skip to content

Conversation

@raspopov
Copy link
Contributor

The max-width increased from 100px to 270px, this is the maximum size at which the navbar menu does not collapse on narrow screens.

Fixes #23593.

The max-width increased from 100px to 270px, this is the maximum size at
which the navbar menu does not collapse on narrow screens.

Fixes #23593.

Signed-off-by: raspopov <raspopov@cherubicsoft.com>
@dregad
Copy link
Member

dregad commented Feb 22, 2025

Not sure about this change. How did you come up with 270px ? When $g_window_title is long, this causes wrapping - navbar displays on 2 lines.

For example:

1024px

image
image

800px

image
image

Of course, with a long enough title, this behavior would happen anyway with the current max width of 100px but it's less likely to occur.

I suppose in this case the expected behavior could be to display just the avatar, a click on which will display a 2nd line with the user menu (similar to what happens on narrow screens) but that's probably opening a big can of worms.

image

@raspopov
Copy link
Contributor Author

When $g_window_title is long, this causes wrapping - navbar displays on 2 lines.

This is fine, the layout is carried over a few lines (where else can it go?) but the text stays solid inside the intact panels. But if the width is more than 270px at the size of a smartphone, the name panel bursts and the frames and down arrow fall off.

If we want a different behavior for the whole header, not just the username field, it's a matter of opening another issue and redesigning the item flow.

By the way, in the original ACE theme, user information can take up multiple rows within its element.

@dregad
Copy link
Member

dregad commented Feb 23, 2025

if the width is more than 270px at the size of a smartphone, the name panel bursts and the frames and down arrow fall off.

You mean this ?

image

If we want a different behavior for the whole header, not just the username field, it's a matter of opening another issue and redesigning the item flow.

Let's not go there, not worth the effort IMHO.

@raspopov
Copy link
Contributor Author

You mean this ?

Yes.

@dregad dregad merged commit c55d891 into mantisbt:master-2.27 Feb 25, 2025
10 of 12 checks passed
@raspopov raspopov deleted the max-width branch February 26, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants