Refactor find-in-page tests to use real settings instead of mocks

[Copilot]

Overview

Refactored src/find-in-page/__tests__/index.test.js to follow the recommended testing pattern by using real settings instead of mocked settings module. This aligns with the patterns established in src/tray/__tests__/index.test.js and src/tab-manager/__tests__/index.test.js.

Changes

Before (Mocked Settings)

beforeEach(() => {
  jest.resetModules();
  jest.mock('electron', () => require('../../__tests__').mockElectronInstance());
  electron = require('electron');
  baseWindow = electron.baseWindowInstance;
  electron.WebContentsView = jest.fn(() => require('../../__tests__').mockWebContentsViewInstance());
  eventBus = electron.ipcMain;
  // Always mock settings unless we want to overwrite the real settings file !
  jest.mock('../../settings');
  require('../../settings').loadSettings.mockImplementation(() => ({
    trayEnabled: true
  }));
  require('../../settings').openSettingsDialog = jest.requireActual('../../settings').openSettingsDialog;
  jest.spyOn(require('../../user-agent'), 'initBrowserVersions')
    .mockImplementation(() => Promise.resolve({}));
  main = require('../../main');
  main.init();
});

After (Real Settings)

beforeEach(async () => {
  jest.resetModules();
  await require('../../__tests__').testSettings();
  jest.mock('electron', () => require('../../__tests__').mockElectronInstance());
  electron = require('electron');
  baseWindow = electron.baseWindowInstance;
  electron.WebContentsView = jest.fn(() => require('../../__tests__').mockWebContentsViewInstance());
  eventBus = electron.ipcMain;
  jest.spyOn(require('../../user-agent'), 'initBrowserVersions')
    .mockImplementation(() => Promise.resolve({}));
  main = require('../../main');
  main.init();
});

Benefits

• Simpler code: Removed 5 lines of complex mocking setup
• Black-box testing: Tests now verify actual integrated behavior rather than implementation details
• Better isolation: Each test suite uses real settings with temporary directories that are automatically cleaned up
• Consistency: Follows the same pattern as other recently refactored tests
• Maintainability: Easier to read and understand without mock complexity

Testing

✅ All 17 find-in-page tests pass
✅ All 627 tests in the full test suite pass
✅ No linting errors
✅ Test structure remains unchanged

Original prompt

The tests in src/find-in-page/tests/index.test.js use mocked settings module.
This is no longer the recommended practice in this repository.
We are now using real settings to ensure integrated behavior and to avoid tests dealing with internal implementations (black-box testing preferred over white-box testing).
Refactor this test suite.
You can check already refactored tests in:

• src/tray/tests/index.test.js
• src/tab-manager/tests/index.test.js

The current test structre should remain untouched. The test should be simpler to read and have less complexity.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[manusa]

LGTM, thx!

[Copilot]

Pull Request Overview

This PR refactors the find-in-page test suite to use real settings instead of mocked settings, following the repository's recommended testing pattern for better integration testing and maintainability.

• Removes complex mocking setup for the settings module
• Adopts real settings with temporary directories for test isolation
• Aligns with patterns established in other recently refactored test suites