Skip to content

[TESTS] Refactor main-window-listeners to use real settings instead of mocks #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

[TESTS] Refactor main-window-listeners to use real settings instead of mocks #526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd65e03
Initial plan
Copilot Oct 1, 2025
1e8151a
Refactor main-window-listeners tests to use real settings
Copilot Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/main/__tests__/main-window-listeners.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ describe('Main :: Main window listeners test suite', () => {
let electron;
let main;
let baseWindow;
beforeEach(() => {
let settings;
beforeEach(async () => {
jest.resetModules();
// Always mock settings unless we want to overwrite the real settings file !
jest.mock('../../settings');
require('../../settings').loadSettings.mockImplementation(() => ({}));
settings = await require('../../__tests__').testSettings();
jest.mock('electron', () => require('../../__tests__').mockElectronInstance({
// Return a **different** instance for each view
BrowserView: jest.fn(() => require('../../__tests__').mockBaseWindowInstance())
Expand Down Expand Up @@ -56,9 +55,7 @@ describe('Main :: Main window listeners test suite', () => {
});
test('with minimize, should minimize the window', () => {
// Given
require('../../settings').loadSettings.mockImplementation(() => ({
closeButtonBehavior: 'minimize'
}));
settings.updateSettings({closeButtonBehavior: 'minimize'});
// When
baseWindow.listeners.close(event);
// Then
Expand Down
Loading