Added copy context from gin to api2go #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the gin's key value store to api2go's key value store. This allows for middleware context values to be set in gin middleware and be used in api2go resources.
Member
|
ok, LGTM and makes sense. Tests are also green except the tip go version that doesn't matter. However you didn't write a test that checks if the context value set is correctly working. Would you like to write a test for this as well? |
Contributor
Author
|
@wwwdata sure thing I'll add a test for it. |
Contributor
Author
|
@wwwdata I've added some tests, please let me know if they are sufficient. |
wwwdata
approved these changes
Aug 2, 2018
routing/gingonic_test.go
Outdated
| Expect(keys).To(Equal(map[string]interface{}{contextKey: *contextValue})) | ||
| }) | ||
|
|
||
| It("context value is not present for user resource", func() { |
wwwdata
approved these changes
Aug 5, 2018
sharpner
approved these changes
Aug 5, 2018
artlo
pushed a commit
to retailnext/api2go
that referenced
this pull request
May 4, 2023
Added copy context from gin to api2go Copy the gin's key value store to api2go's key value store. This allows for middleware context values to be set in gin middleware and be used in api2go resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the gin's key value store to api2go's key value store. This allows for middleware context values to be set in gin middleware and be used in api2go resources.
Fixes: #317