Allow resources to specify meta using the new MarshalMeta interface #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for this PR. Could you please add a test for this as well then we can merge it. |
sharpner
reviewed
Oct 1, 2018
jsonapi/marshal.go
Outdated
| // want any meta. | ||
| type MarshalMeta interface { | ||
| MarshalIdentifier | ||
| GetMeta() Meta |
Member
There was a problem hiding this comment.
I think we should omit the "Get" from the getter (https://golang.org/doc/effective_go.html?#Getters). someStruct.Meta() would read just as nice :)
Contributor
Author
|
I added a basic test and updated the method as per @sharpner recommendation but now the travis-ci build/tests are failing it appears that "github.com/golang/lint/golint" has moved or am I missing something? |
Member
|
Thanks! I opened a separate PR to check if it fixes your problem. ;) #321 |
Member
|
thanks, can you rebase on master, then the travis tests should be running again |
…ributes Revert Inadvertent change to Relationship struct Added Basic test for New GetMeta Interface
Contributor
Author
|
Thanks for resolving the Travis-ci issue rebase on master should be good to go now. 😄 |
wwwdata
approved these changes
Oct 19, 2018
artlo
pushed a commit
to retailnext/api2go
that referenced
this pull request
May 4, 2023
…anyminds#320) - Changed the Meta field to use json.RawMessage type to match which Attributes - Added Basic test for New GetMeta Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the jsonapi Resource Objects should be able to have "meta" member pointing to a "Meta Object"