Custom widget render #1036

yunikkk · 2022-01-11T13:31:31Z

PR is based on POC.

I've added separate GL context that renders all widgets to the texture (if any of widgets are dirty) in the offscreen surface.

New GL context is also shared with the old one thus MapboxRenderThread is able to render the texture with widgets on top of the map.

Seems to be working with approximately the same speed as single context version.

If no widgets are added - separate GL context and rest of the EGL won't be created at all, thus no impact to the performance at all.

Rest of the widgets will be added separately since they are in fact built on top of this PR.

Screenshot of the auto emulator with compass / logo displayed :

kiryldz

Some comments

android-auto-app/build.gradle.kts

android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/CarCameraController.kt

android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/MapSession.kt

app/build.gradle.kts

app/src/main/java/com/mapbox/maps/testapp/examples/customlayer/ExampleCustomLayer.kt

sdk/src/main/java/com/mapbox/maps/renderer/MapboxWidgetRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderThread.kt

extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/BaseWidgetRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/widget/BitmapWidget.kt

sdk/src/main/java/com/mapbox/maps/renderer/gl/GlUtils.kt

sdk/src/main/java/com/mapbox/maps/renderer/gl/TextureRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/widget/BitmapWidgetRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/widget/WidgetPosition.kt

android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/MapSession.kt

sdk/src/main/java/com/mapbox/maps/MapControllable.kt

sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderThread.kt

sdk/src/main/java/com/mapbox/maps/renderer/MapboxSurfaceRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/MapboxTextureViewRenderer.kt

sdk/src/main/java/com/mapbox/maps/renderer/gl/GlUtils.kt

yunikkk · 2022-02-10T12:13:52Z

sdk/src/test/java/com/mapbox/TestUtils.kt

+  verifyBlock = verifyBlock,
+)
+
+internal fun waitZeroCounter(startCounter: Int = 1, timeoutMillis: Int = 1000, runnable: CountDownLatch.() -> Unit) {


Util to ease tests working with CountdownLatches / waiting for the zero and throwing exception afterwards

yunikkk · 2022-02-10T12:23:00Z

sdk/src/test/java/com/mapbox/maps/renderer/MapboxRenderThreadTest.kt

-      throw TimeoutException()
+    initRenderThread()
+    provideValidSurface()
+    waitZeroCounter {


Here and below we need latches since Handler is stopped in destroy().

Other tests are rewritten so that unneeded latches are not created - instead we pause and idle handler thread accordingly to handle posted runnables

extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/CompassWidget.kt

extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/LogoWidget.kt

…xture on top of the map.

yunikkk requested review from kiryldz and pengdev January 11, 2022 13:31

kiryldz reviewed Jan 12, 2022

View reviewed changes

yunikkk force-pushed the yds-custom-widget-render branch 3 times, most recently from 68b792e to 1896355 Compare January 24, 2022 17:32

yunikkk changed the title ~~Custom widget render draft~~ Custom widget render Jan 24, 2022

yunikkk requested a review from a team January 24, 2022 17:44

yunikkk marked this pull request as ready for review January 24, 2022 18:08

yunikkk commented Jan 24, 2022

View reviewed changes

sdk/src/main/java/com/mapbox/maps/renderer/widget/BitmapWidget.kt Outdated Show resolved Hide resolved