fix annotation interactions stop working after annotation update #1063
+157
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maios
reviewed
Nov 11, 2025
Contributor
maios
left a comment
maios
left a comment
There was a problem hiding this comment.
LGTM! Can we add some tests for this use case?
Contributor
Author
To test this we'd need to simulate touch events from the native side, not sure how to do this from the Flutter side. |
pjleonard37
previously approved these changes
Nov 11, 2025
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
pjleonard37
approved these changes
Nov 11, 2025
evil159
added a commit
that referenced
this pull request
Nov 11, 2025
* fix annotation interactions stop working after annotation update * add changelog * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> --------- Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
evil159
added a commit
that referenced
this pull request
Nov 11, 2025
* Annotation improvements (#1064) * allAnnotations + customData * add changelog entry * fix annotation interactions stop working after annotation update (#1063) * fix annotation interactions stop working after annotation update * add changelog * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> --------- Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> --------- Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fixes annotation interaction handlers not being passed to platform SDK upon annotation update.
What is the motivation and context behind this change?
#1026 https://mapbox.atlassian.net/browse/MAPSFLT-413
Pull request checklist:
PRs must be submitted under the terms of our Contributor License Agreement CLA.