This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Expose base path to html #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepta
force-pushed
the
html-inject
branch
2 times, most recently
from
592beeb to
b7c1949
Compare
Contributor
davidtheclark
left a comment
davidtheclark
left a comment
There was a problem hiding this comment.
Since the user can create the HTML with a function, can we provide this information as an argument to the function? I would prefer that to an idiosyncratic templating system.
Contributor
Author
Good idea! |
Contributor
Author
|
@davidtheclark updated the code to allow for passing a function to |
davidtheclark
approved these changes
Jan 23, 2019
Contributor
davidtheclark
left a comment
davidtheclark
left a comment
There was a problem hiding this comment.
Looks good to me 👍
README.md
Outdated
| ### htmlSource | ||
|
|
||
| Type: `string`\|`Promise<string>`. Default:[see the default HTML](https://github.com/mapbox/underreact/blob/next/lib/default-html.js). | ||
| Type: `string`\|`Promise<string>`\|`Function`. Default:[see the default HTML](https://github.com/mapbox/underreact/blob/next/lib/default-html.js). |
Contributor
There was a problem hiding this comment.
You could clarify this annotation as Function<string | Promise<string>>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is no simple way to expose the normalised site base path to the html content of an Underreact project. This PR aims to fix that.
@davidtheclark for review, please.